fix(keeper.py): a nasty string vs. list type error

erikmd · Jul 1, 2024 · 448db62 · 448db62
1 parent f53a3db
commit 448db62
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.10.10
+0.10.11
diff --git a/keeper.py b/keeper.py
@@ -1209,6 +1209,7 @@ def generate_config(docker_repo, gitlab_ci_tags, propagate_data):
         prop = propagate_data[slug]
         strat = prop['strategy']
         if 'item' in strat:
+            check_list(strat['item'])
             item = ','.join(strat['item'])
         else:
             item = ''
@@ -1332,8 +1333,8 @@ def main_write_artifacts(upstream_version, minimal,  # <- input ignored
                           + "unexpected item" % command)
             res_elt = {}
             res_elt['mode'] = command
-            if item:
-                res_elt['item'] = item
+            if item:  # here, a string or comma-separated list
+                res_elt['item'] = uniqify_tags(trim_comma_split(item))
             manual_propagate[slug] = res_elt
         # if debug:
         print_stderr('Specified manual_propagate:')
@@ -1658,6 +1659,8 @@ def test_trim_comma_split():
     assert sorted(flat_map_trim_comma_split(['dev', '8.19,8.20,',
                                              'dev,dev-native'])) == \
         sorted(['8.19', '8.20', 'dev', 'dev', 'dev-native'])
+    assert uniqify_tags(trim_comma_split('dev')) == ['dev']
+    assert uniqify_tags(trim_comma_split('dev,dev,')) == ['dev']
 
 
 if __name__ == "__main__":