feat(dependencies) Add Laravel 6 support #31
Conversation
| @@ -11,13 +11,13 @@ | |||
| ] | |||
| }, | |||
| "require": { | |||
| "laravel/framework": "~5.3" | |||
| "laravel/framework": "~6.0" | |||
There was a problem hiding this comment.
Support for Laravel 6
| "mockery/mockery": "1.3.*", | ||
| "orchestra/testbench": "4.*", | ||
| "phpunit/phpunit": "~8.0", | ||
| "php-coveralls/php-coveralls": "2.2.*", |
There was a problem hiding this comment.
satooshi/php-coveralls is depreceted so replaced by the suggested replacement which worked out fine
| "mockery/mockery": "1.3.*", | ||
| "orchestra/testbench": "4.*", | ||
| "phpunit/phpunit": "~8.0", |
There was a problem hiding this comment.
Update dependencies to meet Laravel 6 needs
| @@ -7,8 +7,7 @@ | |||
| convertNoticesToExceptions="true" | |||
| convertWarningsToExceptions="true" | |||
| processIsolation="false" | |||
| stopOnFailure="false" | |||
| syntaxCheck="false"> | |||
There was a problem hiding this comment.
syntaxCheck is unrecognized on phpUnit 8
| @@ -26,7 +26,7 @@ public function format(JsonResponse $response, Exception $e, array $reporterResp | |||
|
|
|||
| class ExceptionHandlerTest extends TestCase { | |||
|
|
|||
| public function setUp() | |||
| public function setUp() :void | |||
There was a problem hiding this comment.
Match declaration of TestCase with PHPUnit 8
| $this->expectException(\InvalidArgumentException::class); | ||
|
|
||
| $this->expectExceptionMessage('invalid: stdClass is not a valid reporter class.'); |
There was a problem hiding this comment.
setExpectedException is no longer supported on phpUnit 8, so replaced by the equivalent code
| $this->setExpectedException( | ||
| \InvalidArgumentException::class, | ||
| sprintf( | ||
| "% is not a valid formatter class.", | ||
| get_class($formatter) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
setExpectedException is no longer supported in phpUnit 8, so replaced by equivalent code
| @@ -7,7 +7,7 @@ | |||
| class ExceptionFormatterTest extends TestCase | |||
| { | |||
|
|
|||
| public function setUp() | |||
| public function setUp() :void | |||
There was a problem hiding this comment.
Match setUp declaration for phpUnit 8
| @@ -11,16 +11,16 @@ class BugsnagReporterTest extends TestCase | |||
|
|
|||
| protected $client; | |||
|
|
|||
| public function setUp() | |||
| public function setUp() :void | |||
There was a problem hiding this comment.
Match setUp declaration for phpUnit 8
|
Thanks @pablo-bossi ! |
Update dependencies and tests for Laravel 6 support