Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ecovelo systems #640

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add new ecovelo systems #640

merged 2 commits into from
Oct 30, 2023

Conversation

Altonss
Copy link
Contributor

@Altonss Altonss commented Oct 27, 2023

No description provided.

eskerda
eskerda requested changes Oct 30, 2023
View reviewed changes
Copy link
Owner

@eskerda eskerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dataset names may have changed since you opened the pull request? I have suggested new ones that work for me

Thanks!

pybikes/data/ecovelo.json Outdated Show resolved Hide resolved
pybikes/data/ecovelo.json Outdated Show resolved Hide resolved
pybikes/data/ecovelo.json Outdated Show resolved Hide resolved
@Altonss
Update ecovelo.json
af61783 
Fix dataset values
@Altonss
Copy link
Contributor Author

Altonss commented Oct 30, 2023

I think the dataset names may have changed since you opened the pull request? I have suggested new ones that work for me

Thanks!

Sorry for the mistake!

@eskerda
Copy link
Owner

eskerda commented Oct 30, 2023

I think the dataset names may have changed since you opened the pull request? I have suggested new ones that work for me
Thanks!

Sorry for the mistake!

No worries. Looking good, thanks!

@eskerda eskerda merged commit 867985c into eskerda:master Oct 30, 2023
5 checks passed
@Altonss Altonss deleted the patch-8 branch October 30, 2023 13:16
@eskerda
Copy link
Owner

eskerda commented Oct 30, 2023

@Altonss we have added a map report to utils, if you have not seen it, check it out! I think it's very useful

make map! -i T_FLAGS+='-k ecovelo -n 5'
image

https://github.com/eskerda/pybikes/blob/master/utils/README.md

@Altonss
Copy link
Contributor Author

Altonss commented Oct 30, 2023

@Altonss we have added a map report to utils, if you have not seen it, check it out! I think it's very useful

make map! -i T_FLAGS+='-k ecovelo -n 5'
image

https://github.com/eskerda/pybikes/blob/master/utils/README.md

Oh wow, this looks amaizing :) This needs to be run locally right?

@eskerda
Copy link
Owner

eskerda commented Oct 30, 2023

Yes! Let me know If you try it out, and if you run into any problems file an issue and I will look into it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskerda eskerda eskerda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Altonss @eskerda