Update ci #7
Update ci #7
Conversation
NelsonVides
force-pushed
the
update_ci
branch
2 times, most recently
from
d8114fd
to
988f886
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
===========================================
- Coverage 89.94% 71.42% -18.52%
===========================================
Files 2 1 -1
Lines 179 14 -165
Branches 13 0 -13
===========================================
- Hits 161 10 -151
+ Misses 18 4 -14 ☔ View full report in Codecov by Sentry. |
rebar.config.script
Outdated
| Artifacts = case os:type() of | ||
| {win32, _} -> | ||
| [{artifacts, ["priv/fast_pbkdf2.dll"]}]; | ||
| _ -> | ||
| [{artifacts, ["priv/fast_pbkdf2.so"]}] | ||
| end, | ||
|
|
||
| CONFIG ++ Artifacts. |
There was a problem hiding this comment.
@big-r81 can you check that without this it still works for rebar2? I checked source-code for rebar2 and for rebar3+pc and the filetype should be replaced automatically, see for example https://github.com/blt/port_compiler/blob/master/src/pc_port_specs.erl#L220
There was a problem hiding this comment.
@NelsonVides I will test this. The idea behind the "artifacts" isn't the correct naming of the dynamic library (this works with and without the script). It's for the "status" of the build, if the binaries are build correctly. If the build fails, it will give a warning "Hey, the binaries aren't produced" ... And I can't use e.g. an "*" as "priv/fast_pbkdf2.*" as static artifacts "command" in rebar.config.
There was a problem hiding this comment.
All right, will push this PR without the commit removing this, doesn't bother much and we can always remove it later if it turns out to be unneeded. Will merge this when CI passes, thanks for your help 😄
Co-authored-by: Ronny Berndt <[email protected]>
NelsonVides
force-pushed
the
update_ci
branch
from
988f886
to
d916ff1
Compare
Recover #5 with an idea from #6.
CI stopped running in the first PR so I just created a new one.