Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Suppress var() validation errors #45

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: Suppress var() validation errors #45

merged 1 commit into from
Jan 15, 2025

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jan 14, 2025

Prerequisites checklist

What is the purpose of this pull request?

Ensure that property values with var(...) don't throw an error in no-invalid-properties.

What changes did you make? (Give an overview)

  • Catch var() not supported errors from CSS Tree and don't display to the user in no-invalid-properties
  • Updated documentation for no-invalid-properties
  • Added a test

Related Issues

refs #40

Is there anything you'd like reviewers to focus on?

This isn't really a fix for the issue, just suppressing the error for now. This needs to be fixed upstream in CSSTree for a better fix:
csstree/csstree#317

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit f526b1d into main Jan 15, 2025
14 checks passed
@mdjermanovic mdjermanovic deleted the property-vars branch January 15, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants