Use #[instability::unstable] where possible, cleanup and improve consistency #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Jan 29, 2025
bugadani
reviewed
Jan 29, 2025
|
Trait impls look good, but private structs/functions don't really need |
JurajSadel
commented
Jan 29, 2025
…blocks, address review comments
|
I know why it's like this, but do we want it to look like this?
|
…set_interrupt_handler functions vol.2
I've (hopefully) made it more consistent and also have added inherent set_interrupt_handler functions that I've missed in my older PR 🙃 also marked them as unstable so we are consistent here - which makes this PR even more uglier. |
jessebraham
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3022
closes #3023 (not sure if this isn't too brave 😅, I created new project and tried to use SpiDma and it worked as expected)