Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was very brittle. Based on code alignment (which is a symptom, not a cause), the TransferDone interrupt may or may not fire. This behaviour can be triggered by strategically inserting
nop
s - a certain number triggers the bug, one more or less does not. Sometimesnop
s inserted at seemingly unrelated places also change the behaviour.A lot of experimentation leads me to believe that there is some very specific, but (to me) unknown set of conditions, that may prevent the interrupt bit from being set. The issue isn't timing in the sense that inserting a very large delay between start and listen does not trigger the issue - I think the delay has to be very specific.
Code alignment likely had an effect because that timing may have just been precise enough to be sensitive to code cache misses.
This is all very nebulous, but the current PR seems to be resilient against my efforts, so I'm hopeful this issue goes away.