Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio clock refactor #3100

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Radio clock refactor #3100

merged 5 commits into from
Feb 5, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Feb 5, 2025

This PR removes a trait in favour of a driver struct, so that the RADIO_CLK peripheral no longer implements logic. The functionality was moved from system to the clock module and its ll submodules.

@bugadani bugadani added the skip-changelog No changelog modification needed label Feb 5, 2025
@bugadani
Copy link
Contributor Author

bugadani commented Feb 5, 2025

How on Earth did this turn into +800 -1200 lines 😶

@bugadani
Copy link
Contributor Author

bugadani commented Feb 5, 2025

I wanted to merge RadioPeripherals into Peripheral so that we don't special-case them so much, and we'd also get refcounting for free (as in, in terms of work), might still do that in a follow-up.

MabezDev
MabezDev approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would like a bit of testing around the phy clock change, just so we don't break esp-wifi with it

esp-wifi/src/common_adapter/mod.rs Outdated Show resolved Hide resolved
@bugadani bugadani mentioned this pull request Feb 5, 2025
Merged
bjoernQ
bjoernQ approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing and everything seems to work (also the changes are mostly "mechanical")

@bjoernQ bjoernQ added this pull request to the merge queue Feb 5, 2025
Merged via the queue into esp-rs:main with commit 715e447 Feb 5, 2025
27 checks passed
@bugadani bugadani deleted the radio_clk branch February 5, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @bjoernQ @MabezDev