Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LSC smart plug with monitoring 3202087 #1016

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Virusmater
Copy link

Brief description of the changes

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit c8e60aa
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/67a92d3c904849000823bd32
😎 Deploy Preview https://deploy-preview-1016--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Virusmater
Copy link
Author

First time contributing, let me know if something has to be changed

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time contributing, let me know if something has to be changed

  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Please make sure that you read any boxes that you check. The configuration in this PR is a lot more than hardware definitions.

@esphome
Copy link

esphome bot commented Feb 13, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft February 13, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants