Add Dockerfile for deploying the application #15
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Dockerfile for deploying the application. The Dockerfile sets up a Ubuntu 22.04 environment with necessary packages such as tightvncserver, xfce4, qtcreator, and vim-tiny. It also creates directories and copies application files. The Dockerfile_entrypoint.sh script is included to configure the VNC server and startup script. The container is started with the entrypoint.sh script.
tbukovics
requested changes
Nov 19, 2024
|
|
||
| # Create directories | ||
| RUN mkdir -p /ess/ecdc/daqlite/build /ess/ecdc/daqlite/configs | ||
|
|
There was a problem hiding this comment.
I would create this dummy kafka config to prevent erros if daqlite looing for it.
Suggested change
| RUN echo "{}" > /ess/ecdc/daqlite/configs/kafka-config-daqlite.json | |
|
|
||
| ENV DAQLITE_HOME="/ess/ecdc/daqlite/build" | ||
| ENV DAQLITE_CONFIG="/ess/ecdc/daqlite/configs" | ||
| ENV DAQLITE_PRODUCTION=false |
There was a problem hiding this comment.
change it to true
Suggested change
| ENV DAQLITE_PRODUCTION=false | |
| ENV DAQLITE_PRODUCTION=true |
| @@ -0,0 +1,54 @@ | |||
| # docker build --build-arg VNC_PASSWORD=<secret> -f Dockerfile.deploy -t registry.esss.lu.se/ecdc/ess-dmsc/daqlite:<x.x> . | |||
There was a problem hiding this comment.
please move these docker files into a subfolder
tbukovics
reviewed
Nov 19, 2024
| RUN mkdir -p /ess/ecdc/daqlite/build /ess/ecdc/daqlite/configs | ||
|
|
||
| # Copy application files | ||
| COPY build/bin /ess/ecdc/daqlite/build/bin |
There was a problem hiding this comment.
I think on the daqlite machine we use daqlite/bin and we do not have the "build" before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Dockerfile for building image from "build" artifact.
The Dockerfile sets up a Ubuntu 22.04 environment with necessary packages such as tightvncserver, xfce4, qtcreator, and vim-tiny. The Dockerfile_entrypoint.sh script is included to configure the VNC server and startup script.
The Dockerfile.deploy can be integrated in Gitlab CI publish step