Adding support for Docker build/run #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a chance for this PR to be accepted? Is there anything more I have to accomplish? Thanks. |
karlp
reviewed
Nov 11, 2020
| @@ -0,0 +1,15 @@ | |||
| FROM ubuntu:14.04 | |||
karlp
reviewed
Nov 11, 2020
| @@ -70,6 +72,9 @@ optional arguments: | |||
| (multiprocessing) (default: 1) | |||
| ``` | |||
|
|
|||
| If using Docker version, | |||
| docker run flaviostutz/mqtt-malaria [options] | |||
There was a problem hiding this comment.
I'm not going to link to third party builds I'm sorry.
karlp
reviewed
Nov 11, 2020
| @@ -79,6 +84,11 @@ sending as fast as the code allows. | |||
| malaria publish -P 8 -n 10000 -H mqtt.example.org -s 100 | |||
| ``` | |||
|
|
|||
| For doing the same as above, now using the containerized version: | |||
| ``` | |||
| docker run flaviostutz/mqtt-malaria publish -P 8 -n 10000 -H mqtt.example.org -s 100 | |||
There was a problem hiding this comment.
same here, either convert this to syntax for a locally built docker, or drop it entirely, require container people know what they're doing.
|
I don't remember seeing this when you first filed it sorry. I've added a couple of comments to the PR, but note that I've not run or used this code in.... many years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.