Merge pull request #146 from etalab/harden/flaky-test

Try to fix flaky test

spec/jobs/deliver_authorization_request_webhook_job_spec.rb

@@ -1,9 +1,15 @@
 require 'rails_helper'
 
 RSpec.describe DeliverAuthorizationRequestWebhookJob do
-  subject { job_instance.perform_now }
+  subject(:deliver_authorization_request_webhook) { job_instance.perform_now }
+
+  before do
+    ActiveJob::Base.queue_adapter = :inline
+  end
 
   after do
+    ActiveJob::Base.queue_adapter = :test
+
     Rails.application.credentials.webhooks.api_entreprise.url = nil
     Rails.application.credentials.webhooks.api_entreprise.token = nil
   end
@@ -44,7 +50,7 @@
     end
 
     it 'does nothing' do
-      subject
+      deliver_authorization_request_webhook
 
       expect(webhook_post_request).not_to have_been_requested
     end
@@ -56,7 +62,7 @@
     end
 
     it 'does nothing' do
-      subject
+      deliver_authorization_request_webhook
 
       expect(webhook_post_request).not_to have_been_requested
     end
@@ -69,14 +75,12 @@
     end
 
     it "performs a post request on target api's webhook url with payload and headers" do
-      subject
+      deliver_authorization_request_webhook
 
       expect(webhook_post_request).to have_been_requested
     end
 
     describe "target's api webhook url status" do
-      subject { job_instance.perform_now }
-
       before do
         allow(job_instance).to receive(:webhook_fail!)
       end
@@ -85,13 +89,13 @@
         it 'does not reschedule worker' do
           expect(job_instance).not_to receive(:webhook_fail!)
 
-          subject
+          deliver_authorization_request_webhook
         end
 
         it 'does not track on sentry' do
           expect(Sentry).not_to receive(:capture_message)
 
-          subject
+          deliver_authorization_request_webhook
         end
 
         context 'when body is a json with a token_id key' do
@@ -105,7 +109,7 @@
 
           it 'stores this token id in authorization_request' do
             expect {
-              subject
+              deliver_authorization_request_webhook
             }.to change { authorization_request.reload.linked_token_manager_id }.to(token_id)
           end
         end
@@ -117,27 +121,27 @@
         it 'reschedules job' do
           expect(job_instance).to receive(:webhook_fail!)
 
-          subject
+          deliver_authorization_request_webhook
         end
 
         it 'tracks on sentry' do
           expect(Sentry).to receive(:capture_message)
 
-          subject
+          deliver_authorization_request_webhook
         end
 
         context 'when last retry_on attempt fails' do
-          subject { job_instance.perform_now }
-
           let(:tries_count) { described_class::TOTAL_ATTEMPTS }
           let(:response) { instance_double(Faraday::Response, status:, body:) }
 
           before do
             allow(job_instance).to receive_messages(request: response, attempts: described_class::TOTAL_ATTEMPTS)
+
+            ActiveJob::Base.queue_adapter = :test
           end
 
-          it 'sends an email through WebhookMailer' do
-            subject
+          it 'sends an email through WebhookMailer to instructors' do
+            deliver_authorization_request_webhook
 
             expect(ActionMailer::MailDeliveryJob).to(
               have_been_enqueued.with(