Multiple bugfixes #138
Merged
Multiple bugfixes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skelz0r
force-pushed
the
ops/bugfixes
branch
4 times, most recently
from
8716d1f to
8b34a1b
Compare
|
A ce stade là les webhooks créent bien des models sur API Entreprise, mais je n'ai pas de jeton, problème côté API E. |
skelz0r
force-pushed
the
ops/bugfixes
branch
2 times, most recently
from
fb23300 to
76bd218
Compare
This E2E starts from the interactor, enqueue the job and execute it. Before this commit, this entire stack was not execute within the basecode.
1. intitule/description is not required and can't be undefined for some authorization requests 2. `contacts` was renamed `team_members` 3. `demarche` is an id, not a name 4. `team_members` has the applicant as "demandeur"
By default ActiveModel::Serializer seems to include only 1-depth level of associations. We have to explicitly include events.user to our serialization, otherwise authorization_request->events[]->user is missing
In order not to spam in staging
There is orphan events on an authorization request event. This commit harden links and dependent destroy between entities. Should be OK to destroy an authorization request now.
Previous commit exclude events unused eager loads (false positive)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP des erreurs que je dépile en staging