BUGFIX Summary submit which cleans checked scopes not included by default #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skelz0r
force-pushed
the
bugfix/scopes-cleaned
branch
from
cc55719 to
e1c1854
Compare
…ault This is a known limitation of the HTTP protocol: the specification ignores checkbox checked and disabled (context/source https://www.ruby-forum.com/t/check-box-tag-and-disabled-disabled-problem/59023/2) The previous version tackles this by including an hidden input for included scopes (which are disabled by default) when we are currently filling the authorization request (ref f6a9ace) However, when we are on the summary page, all checkboxes are disabled, so we have to include this hidden input too on previous checked scopes, for the same reason as described above.
skelz0r
force-pushed
the
bugfix/scopes-cleaned
branch
from
e1c1854 to
e57bd92
Compare
Isalafont
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a known limitation of the HTTP protocol: the specification ignores checkbox checked and disabled (context/source https://www.ruby-forum.com/t/check-box-tag-and-disabled-disabled-problem/59023/2)
The previous version tackles this by including an hidden input for included scopes (which are disabled by default) when we are currently filling the authorization request (ref f6a9ace)
However, when we are on the summary page, all checkboxes are disabled, so we have to include this hidden input too on previous checked scopes, for the same reason as described above.