Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix flaky test (2nd attempt) #151

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Try to fix flaky test (2nd attempt) #151

merged 1 commit into from
Apr 8, 2024

Conversation

skelz0r
Copy link
Member

@skelz0r skelz0r commented Apr 8, 2024

Ref 390478f

Simplify with a simpler mock, not sure of the behaviour of let!(:body), the test is red on a specific seed 1/10 times, so strange.

Ref 390478f

Simplify with a simpler mock, not sure of the behaviour of
`let!(:body)`, the test is red on a specific seed 1/10 times, so
strange.
@skelz0r skelz0r self-assigned this Apr 8, 2024
@skelz0r
Copy link
Member Author

skelz0r commented Apr 8, 2024

Je crois que c'est la bonne cette fois-ci

@skelz0r skelz0r requested review from mehdi-farsi and Isalafont April 8, 2024 10:16
Copy link
Contributor

@mehdi-farsi mehdi-farsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skelz0r skelz0r merged commit 532e82d into develop Apr 8, 2024
7 checks passed
@skelz0r skelz0r deleted the bugfix/flaky-test branch April 8, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants