Add missing checkbox for api_impot_part_sandbox forms #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Isalafont
commented
Jan 16, 2025
Isalafont
commented
- add attributes data: { 'dpd_homologation_checkbox' => '1' } to api_impot_particulier_sandbox seeds
Isalafont
requested review from
SchweisguthN,
jbfeldis,
skelz0r and
JeSuisUnCaillou
SchweisguthN
approved these changes
Jan 16, 2025
skelz0r
requested changes
Jan 16, 2025
app/lib/seeds.rb
Outdated
| @@ -53,7 +53,7 @@ def create_authorization_requests_for_clamart | |||
| authorization_request = create_submitted_authorization_request(:api_entreprise, attributes: { intitule: 'Place des entreprises', applicant: another_demandeur }) | |||
| send_message_to_instructors(authorization_request, body: "Je ne suis pas sûr du cadre de cette demande, pouvez-vous m'aider ?") | |||
|
|
|||
| create_validated_authorization_request(:api_impot_particulier_sandbox, attributes: { intitule: 'Demande de retraite progressive en ligne', applicant: demandeur }) | |||
| create_validated_authorization_request(:api_impot_particulier_sandbox, attributes: { intitule: 'Demande de retraite progressive en ligne', applicant: demandeur, data: { 'dpd_homologation_checkbox' => '1' } }) | |||
There was a problem hiding this comment.
Pourquoi ce n'est pas dans la factory ? Ce n'est pas le rôle des seeds de savoir comment construire une demande valide. Idem pour en dessous.
|
Y'a une question plus large ici d'ailleurs : cette checkbox est présente sur l'ensemble des demandes en sandbox mais pas en production. Toutes les autres data sont partagées, pourquoi pas celle là ? cc @SchweisguthN |
skelz0r
approved these changes
Jan 20, 2025
skelz0r
deleted the
feature/dat-814-rajouter-la-checkbox-manquante-sur-les-formulaires-sandbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.