Stocke les donnees dans hubee #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
jbfeldis
force-pushed
the
stocke-les-donnees-dans-hubee
branch
from
35e4d6b to
2d5ccfa
Compare
jbfeldis
force-pushed
the
accepte-connexion-france-connect
branch
from
e2b057e to
fcfd6b5
Compare
jbfeldis
force-pushed
the
stocke-les-donnees-dans-hubee
branch
from
2d5ccfa to
6bc67b1
Compare
This was referenced May 23, 2024
skelz0r
reviewed
May 24, 2024
skelz0r
requested changes
May 24, 2024
There was a problem hiding this comment.
Vu la taille de la PR j'ai surement loupé des trucs, on verra à la 2e review.
Pour moi y'a 2 gros points:
- Le naming de l'organizer d'HubEE qui pour moi est pas assez précis (tout est dans le commentaire) ;
- Le
recipientqui semble représenté 2 choses différentes dans le code à clarifier.
Le reste c'est du détails
jbfeldis
force-pushed
the
accepte-connexion-france-connect
branch
from
fcfd6b5 to
18e8857
Compare
jbfeldis
force-pushed
the
stocke-les-donnees-dans-hubee
branch
2 times, most recently
from
9456c3d to
014e63d
Compare
jbfeldis
force-pushed
the
accepte-connexion-france-connect
branch
from
18e8857 to
b4348b5
Compare
jbfeldis
force-pushed
the
stocke-les-donnees-dans-hubee
branch
3 times, most recently
from
bd47a2d to
9753d3d
Compare
jbfeldis
force-pushed
the
stocke-les-donnees-dans-hubee
branch
from
9753d3d to
8c5372d
Compare
jbfeldis
force-pushed
the
accepte-connexion-france-connect
branch
from
b4348b5 to
7542282
Compare
skelz0r
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR inclut un chemin complet (pour le moment visuellement peu présentable) de stockage des informations dans HubEE.
Ces informations ne sont pas officielles pour le moment car l'appel à l'api QFv2 est surchargé localement et les fichiers écrits dans HubEE sont statiques.
Cette PR met aussi en place les tests unitaires 🎉