Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robustness track record section to make tracking easier #18900

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

serathius
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (12b47c2) to head (78c969f).
Report is 22 commits behind head on main.

Current head 78c969f differs from pull request most recent head 7a81c5f

Please upload reports for the commit 7a81c5f to get more accurate results.

Files with missing lines Patch % Lines
server/etcdmain/grpc_proxy.go 6.45% 29 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdmain/grpc_proxy.go 14.52% <6.45%> (-0.53%) ⬇️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18900      +/-   ##
==========================================
+ Coverage   68.69%   68.71%   +0.02%     
==========================================
  Files         420      420              
  Lines       35532    35558      +26     
==========================================
+ Hits        24409    24435      +26     
- Misses       9686     9697      +11     
+ Partials     1437     1426      -11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b47c2...7a81c5f. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea - Thanks @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jmhbnz,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 2c7345a into etcd-io:main Nov 15, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants