Upgrade gtest: 1.13.0 -> 1.16.0 #1301
Open
+15
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
albestro
force-pushed
the
alby/upgrade-gtest
branch
2 times, most recently
from
7f22953 to
9242536
Compare
albestro
force-pushed
the
alby/upgrade-gtest
branch
from
9242536 to
7cb3c2e
Compare
|
cscs-ci run |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 141 141
Lines 8655 8655
Branches 1110 1110
=======================================
Hits 8229 8229
Misses 239 239
Partials 187 187 ☔ View full report in Codecov by Sentry. |
rasolca
approved these changes
Mar 4, 2025
|
cscs-ci run |
RMeli
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTest 1.13.0 have as minimum requirement CMake 3.5 which has been deprecated (moreover we were using it with a patch). Starting from 1.14.0 the requirement has been updated to CMake 3.13.
Since I didn't face any problem with the newest version, I opted for doing the full step. In case we'd see problems in the CI, we can always downscale the upgrade to one of the intermediate steps.