-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiki - PBS research content #162
Conversation
Wiki Page for PBS
* Add page on PBS * Update PBS entry * Update PBS entry * Fixed typos * Incorporate feedback into PBS entry * Fix typos * Nits and fixes --------- Co-authored-by: Mário Havel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alot of relevant details are not readable, due to sheer length of the ePBS entry. Also the relevant parts' readability is undermined due some other parts like desirable properties, for and against arguments and other alike parts.
Can you please identify which specific parts are not readable for you? I wrote ePBS to be a self-contained page where you can learn all the nuances about enshrining PBS. If you follow the feedback from outside Ethereum (e.g. Flashbots group, Hasu, Jon Charbonneau, relayers, etc.), you will see two main categories of discussion and opposition to the current implementations:
So, understanding from the first principles which specific properties a minimum viable ePBS implementation should have helps addressing two above problems. I added these references and the Ethereum Foundation's ePBS rollcalls/breakout meetings in my document fully grasp the nuances of enshrining PBS mechanism. |
The content is definitely well researched, and I think this PR should be merged since it has been open for too long anyway, but some points to consider, maybe us or someone else can curate it in future PR:
What do you think @thogiti? but I agree that this can be potentially done in future PR, this serves as a good foundation for this wiki page |
cross reference links added for epbs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The PBS wiki pages are ready to be shipped to the main branch.
Additional changes and glossary will be added in future PR.
@taxmeifyoucan This PBS section is ready to be merged into main branch. Thank you for your contributions @shyam-patel-kira @arynyestos @raxhvl @taxmeifyoucan @thogiti. |
This should close #93 |
This comment was marked as resolved.
This comment was marked as resolved.
I will push another commit to address these typos. Give me five minutes. |
Once again, huge thanks to all of you for working on all of this! Great job guys, it's an amazing piece of content. I read it again and added some resources, rephrased few things. I agree with points by @shyam-patel-kira above, the content could be more lean and improve readability of long section. Also, there still are more resources that could be linked, I was surprised that the builder spec was not mentioned. Maybe after Barnabes talk today you will find some more improvements. For now let's merge it and have another PR in the future, thanks a lot |
PBS wiki
Adding multiple pages on PBS and related MEV topics.
.md
files and fix any spelling errors before pushing the commit.