Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kt-devnet: add missing network params for supervisor #14708

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

pcw109550
Copy link
Contributor

Description

Adds missing params. Although they are filled in when not provided, worth to provide explicitly.

Tests

Monorepo interop-devnet succeeds.

Metadata

Merge this after ethpandaops/optimism-package#187 is merged.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.70%. Comparing base (7cab3e7) to head (87e42a7).

❗ There is a different number of reports uploaded between BASE (7cab3e7) and HEAD (87e42a7). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (7cab3e7) HEAD (87e42a7)
cannon-go-tests-32 3 1
cannon-go-tests-64 3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14708       +/-   ##
============================================
- Coverage    78.60%   46.70%   -31.90%     
============================================
  Files          174     1040      +866     
  Lines        10547    89994    +79447     
============================================
+ Hits          8290    42032    +33742     
- Misses        2065    44852    +42787     
- Partials       192     3110     +2918     
Flag Coverage Δ
cannon-go-tests-32 62.07% <ø> (-2.01%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.64%) ⬇️
contracts-bedrock-tests 94.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 876 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcw109550 pcw109550 marked this pull request as ready for review March 7, 2025 11:14
@pcw109550 pcw109550 requested a review from a team as a code owner March 7, 2025 11:14
@pcw109550 pcw109550 requested a review from blmalone March 7, 2025 11:14
@sigma sigma added this pull request to the merge queue Mar 7, 2025
Merged via the queue into develop with commit 6f68dc3 Mar 7, 2025
46 checks passed
@sigma sigma deleted the pcw109550/kt-devnet-supervisor-network-param branch March 7, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants