Replace pyelliptic with pyca/cryptography #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Wolf480pl
force-pushed
the
replace-pyelliptic
branch
from
2aa4198 to
1857e20
Compare
1 similar comment
Wolf480pl
force-pushed
the
replace-pyelliptic
branch
from
6031bad to
7edca70
Compare
2 similar comments
Wolf480pl
force-pushed
the
replace-pyelliptic
branch
from
7edca70 to
1c8a8b8
Compare
Wolf480pl
force-pushed
the
replace-pyelliptic
branch
from
9def693 to
c073b32
Compare
gsalgado
reviewed
Sep 18, 2017
| cipher = Cipher(algorithms.AES(self.aes_secret), modes.CTR(iv), default_backend()) | ||
| self.aes_enc = cipher.encryptor() | ||
| self.aes_dec = cipher.decryptor() | ||
|
|
||
| self.mac_enc = AES.new(self.mac_secret, AES.MODE_ECB).encrypt |
There was a problem hiding this comment.
Woudln't it be possible to use Cipher(algorithms.AES(self.mac_secret), modes.ECB(), default_backend()).encryptor().update here, to avoid depending on two different crypto libs?
There was a problem hiding this comment.
I was trying to keep my changes minimal.
There was a problem hiding this comment.
Also, changing this line won't let us get rid of pycryptodome dependency - we also use it for keccak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I didn't screw up some details in the crypto, but I'm no expert.
Please, someone review it.
This should fix #58