This repository has been archived by the owner on Aug 8, 2018. It is now read-only.
closes #99 eth_gasLimit missing #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels really foolish, but what am I supposed to do to make the test work? I thought I should use a call similar to this: https://github.com/ethereum/pyethapp/blob/develop/pyethapp/rpc_client.py#L101 |
|
@4gn3s It returns the 'earliest' because the 'call' method is redefined on line 6 75a2572#diff-e92b78f8db16a62992c87795ab883c44L4 |
|
@4gn3s There is nothing wrong with your code, It's all about the incorrect tests. You need starting the RPC Server before trying to connect to it. |
# Conflicts: # pyethapp/rpc_client.py # pyethapp/tests/test_rpc_client.py
|
Thanks @RomanZacharia, I've fixed the tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.