refactor: rename era2 to e2ss
#1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
approved these changes
Feb 4, 2025
| @@ -15,20 +15,20 @@ era is a format for storing beacon chain data more information can be found here | |||
|
|
|||
| era1 is a format for storing all of Ethereum's pre merge blocks. It contains block headers, block bodies, and receipts for pre-merge block history which ranges block 0-15537394 | |||
|
|
|||
| ## What is era2? | |||
| ## What is e2ss? | |||
There was a problem hiding this comment.
Like here we use e2ss...
crates/e2store/README.md
Outdated
|
|
||
| TODO: Add chart of snapshot size at every million block interval. | ||
|
|
||
| ### Era2 analysis tool | ||
| ### E2ss analysis tool |
There was a problem hiding this comment.
And here we use E2ss... Though, I get it's the first word which is usually capitalized... but, I'd still rather see e2ss or E2SS here
morph-dev
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
So I talked with @arnetheduck and we will be renaming
era2toe2ssfor 2 reasonserawill be reserved for Ethereum chain history whether that is EL/CL/BothHow was it fixed?
renaming era2 to e2ss
Paul will be updating era2.ethportal.net to e2ss.ethportal.net and updating the file type to e2ss, I won't merge this PR until that is done