Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shibuya City #9

Merged
merged 3 commits into from
May 12, 2024
Merged

Add Shibuya City #9

merged 3 commits into from
May 12, 2024

Conversation

kurotaky
Copy link
Member

Shibuya City logo added to Community supporters! 🗼

@neila
Copy link
Member

neila commented May 12, 2024

2ee517d でCIコケたのはimport順です

なので 7167d71 でファイル名を大文字にしても解決しません

またgitのデフォルト挙動としてファイル名の大文字小文字は同一として扱われるので、逆にファイル参照エラーが起きていると言った感じです(これは大文字小文字以外の形でgitに変更を加えれば解消します)

@kurotaky kurotaky merged commit 9bb40fc into main May 12, 2024
3 checks passed
@kurotaky kurotaky deleted the add-shibuya-logo branch May 12, 2024 08:05
@kurotaky
Copy link
Member Author

レビューありがとうございます!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants