New schema validation module #128
Conversation
| @@ -0,0 +1,11 @@ | |||
| package eu.europeana.api.commons; | |||
|
|
|||
| public class JsonSchemaLoadingFailedException extends RuntimeException{ | |||
There was a problem hiding this comment.
should be moved to an exception package
| @@ -0,0 +1,6 @@ | |||
| package eu.europeana.api.commons; | |||
|
|
|||
| public interface JsonSchemaLocation { | |||
There was a problem hiding this comment.
This class is not needed here.
JsonSchemaLocation interface only contains the classpath information which is used in the calling API and not here. JSON schema location will be specific for each API and will be present in the calling API not here.
| import java.util.List; | ||
|
|
||
| @Configuration | ||
| public class JsonValidationConfiguration implements WebMvcConfigurer { |
There was a problem hiding this comment.
This class is not required in API-commons, it is to be added in the implementation/calling API where you want to inform the Spring about our JsonSchemaValidatingArgumentResolver.
| public class JsonValidationConfiguration implements WebMvcConfigurer { | ||
|
|
||
|
|
||
| @Autowired |
There was a problem hiding this comment.
this is a wrong spring injection by the way
| import com.networknt.schema.ValidationMessage; | ||
| import java.util.Set; | ||
|
|
||
| public class JsonValidationFailedException extends RuntimeException { |
There was a problem hiding this comment.
move it to the exception package
| import org.junit.jupiter.api.Test; | ||
|
|
||
|
|
||
| class CommonsSchemavalidationApplicationTests { |
There was a problem hiding this comment.
this test class is doing nothing except context loading. Would be nice top add some tests or remove this
No description provided.