-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt Libint library for Windows #270
Conversation
d8a691f
to
821b4aa
Compare
821b4aa
to
86b2d06
Compare
@evaleev , don't worry too much about the GHA fails on master. I ran into the "Repo" stage skipping once before and tried to make the "Export" stage skip with https://github.com/evaleev/libint/blob/master/.github/workflows/cmake.yml#L165 (can't run b/c no tarball produced by "Repo" stage), but apparently that doesn't work. I'll try something else. |
86b2d06
to
bd318ca
Compare
Ok, this PR is rebased to master, and GHA checks out. |
@loriab what's the issue with |
I don't recall the actual error with |
b47208d
to
607fdb4
Compare
From the install below, it looks like Windows plain wasn't coping with the star character. I've now modified it so the star files don't get installed for Windows. Note that for all OSes, while the
|
Ok, full GHA passing again. The |
The below shows some promise (on Linux) for filtering out the star files. I'll try it out when rebasing 271 if there isn't another GHA run before then.
|
607fdb4
to
85b2040
Compare
85b2040
to
e4af31f
Compare
Install working now -- description in PR frontmatter. |
I think this is ready for consideration. After this is merged, there's a couple extra changes I can make to #271 (now that SH ordering isn't a choice at generation-time for multipoles) while doing its rebase. I'm glad to make more changes here, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @loriab !
thanks! I'll get #271 prepared. |
(currently atop #269)(in decreasing order of importance)
Windows doesn't like files with*
in the name, so6-311g**.g94
,6-31g**
,6-31g*
, and6-31G*
are renamed in the library and in tests to6-311gss.g94
, etc. If more Pople basis sets are planned, should instead do something like https://github.com/psi4/psi4/blob/1a971f184783b3e5c02e0055f508918d6fb56355/psi4/driver/qcdb/basislist.py#L162-L167, so the first becomes6-311g_d_p_.g94
*
in the name (shows as unprintable,
), so6-311g**.g94
,6-31g**
,6-31g*
, and6-31G*
are symlinked in the repo to6-311gss.g94
, etc. For all OS, either "s" or "*" in the basis string name accesses the basis set. For Windows, only the "s" g94 files are installed, while for other OSes, both variants are installed. An extra test is added to unit/basis to show both work.INSTALL_INTERFACE:DATADIR
so that it is relocatable when_IMPORT_PREFIX
defined inlibint2-config.cmake
. The current syntax only works for Unix; conda is handling the Windows case that's painful to iteratively debug.