Drop _use_proxy from plugin #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one defined in snapcraft's maven plugin is more correct: this version never returns true for a Launchpad build because SNAPCRAFT_LOCAL_SOURCES is only defined in the pull phase; and there's no reason to diverge from the maven plugin on this anyway.
|
(This won't immediately cause builds of this snap on Launchpad to start working, but I have a set of launchpad-buildd changes in progress that I'm testing on this snap. This fix is a prerequisite.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one defined in snapcraft's maven plugin is more correct: this
version never returns true for a Launchpad build because
SNAPCRAFT_LOCAL_SOURCES is only defined in the pull phase; and there's
no reason to diverge from the maven plugin on this anyway.