Skip to content

Commit

Permalink
Fix failing CI because "build" needs to be run before "check" now.
Browse files Browse the repository at this point in the history
  • Loading branch information
evanderkoogh committed Sep 16, 2024
1 parent 01a8835 commit 0a41148
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 18 deletions.
5 changes: 5 additions & 0 deletions .changeset/four-students-divide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@microlabs/otel-cf-workers': minor
---

Complete overhaul of the build system thanks to @Cherry
6 changes: 1 addition & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,5 @@ jobs:
cache: 'pnpm'
- name: 'Install NPM Dependencies'
run: 'pnpm install --frozen-lockfile --child-concurrency=10'
- name: 'Check for Errors'
run: 'pnpm check'
- name: 'Check the build'
run: 'pnpm build'
- name: 'Run Tests'
run: 'pnpm test'
run: 'pnpm run ci'
6 changes: 1 addition & 5 deletions .github/workflows/pullrequests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,5 @@ jobs:
cache: 'pnpm'
- name: 'Install NPM Dependencies'
run: 'pnpm install --frozen-lockfile --child-concurrency=10'
- name: 'Check for Errors'
run: 'pnpm check'
- name: 'Check the build'
run: 'pnpm build'
- name: 'Run Tests'
run: 'pnpm test'
run: 'pnpm run ci'
6 changes: 0 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ jobs:
node-version: 20
- name: 'Install NPM Dependencies'
run: 'pnpm install --frozen-lockfile --child-concurrency=10'
- name: Check the build
run: pnpm build
- name: 'Check for Errors'
run: 'pnpm check'
- name: 'Run Tests'
run: 'pnpm test'
- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@v1
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,15 @@
"build": "run-s -l build:versions build:src",
"cs-version": "changeset version",
"cs-publish": "changeset publish",
"release": "run-s -l clean cs-version build cs-publish",
"release": "run-s -l clean cs-version build check cs-publish",
"check": "run-s -l check:*",
"check:format": "prettier . --check --ignore-unknown",
"check:types": "tsc --noEmit",
"watch": "tsc --watch",
"prepare": "husky",
"test": "vitest run",
"test:dev": "vitest"
"test:dev": "vitest",
"ci": "run-s -l clean build check && pnpm test"
},
"files": [
"dist"
Expand Down

0 comments on commit 0a41148

Please sign in to comment.