Added check to allow callback be sent to options argument #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. This will work for now. I wonder if, with the 1.0 (ie API breaking) release I wonder if it would be beneficial to move the data attribute into the options object. That would make the API work better with node's callback style. |
|
Yes, also was thinking of possibly breaking code up into modules for version 1.0. Make it easier to maintain and organize. |
|
I'm a bit conflicted about that. Not because it isn't a great idea (ie it is) but because I'd like to lock this in at 1.0 and start a new clean room implementation that leverages the latest JS best practices. I created #129 to outline the specifics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added checks that will allow passing of callback function to 2nd options argument.
Will log error message and return function if callback function was passed to 2nd argument AND 3rd argument was passed.
References
#48
Notes
Need to look into cleaning up code base, lot of duplicate code needed.