Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added emmet-sqlite to workspace #154

Merged

Conversation

davecosec
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davecosec, could you also add sqlite package to:

to complete setup?

The package-lock changes indeed looks suspicious, but might be that those are needed sqlite3 dependencies or peer dependencies 🤷

@davecosec
Copy link
Collaborator Author

The package-lock changes indeed looks suspicious, but might be that those are needed sqlite3 dependencies or peer dependencies 🤷

TryGhost/node-sqlite3#1800

hrm..

@oskardudycz
Copy link
Collaborator

The package-lock changes indeed looks suspicious, but might be that those are needed sqlite3 dependencies or peer dependencies 🤷

TryGhost/node-sqlite3#1800

hrm..

Let’s keep it as it is, for now, and later consider switching to better sqlite3 if it appears better maintained and fulfilling our needs.

@oskardudycz oskardudycz marked this pull request as ready for review December 22, 2024 17:03
@oskardudycz
Copy link
Collaborator

Thanks @davecosec, I’m pulling that in 👌

@oskardudycz oskardudycz merged commit e00ecf1 into event-driven-io:main Dec 22, 2024
1 check passed
@oskardudycz oskardudycz added this to the 0.23.0 milestone Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants