Partial #169 - MongoDB EventStore onAfterCommit hook
#170
Conversation
|
Ended up just throwing an expect error declaration on it to prevent other build errors in emmet |
| @@ -388,6 +393,15 @@ class MongoDBEventStoreImplementation implements MongoDBEventStore, Closeable { | |||
| ); | |||
| } | |||
|
|
|||
| await tryPublishMessagesAfterCommit<MongoDBEventStore>( | |||
| // @ts-expect-error Issues with `globalPosition` not being present causing the type for metadata to expect `never` | |||
There was a problem hiding this comment.
@alex-laycalvert, that's weird; I noticed that TS got crazy on my other computer, but when I reinstalled fresh packages, then it worked fine. I'm not sure if that's the same issue, but I'll check the typing after the merge 👍
There was a problem hiding this comment.
Don't know for sure but I wonder if it has to do with the infer GV usage not working if global position is not on the type itself, even if we allow undefined.
There was a problem hiding this comment.
Yes, because technically, it's not undefined but optional. TypeScript is treating those cases differently. I'll have a look, it might be that I messed something out.
Description
onAfterCommithook to theMongoDBEventStoreoptions modeled after the in-memory event storeinMemoryEventStore.onAfterCommittestAdjusts the typing ofEventStoreReadEventMetadatato allow for an undefinedGlobalPosition. Without this change, attempting to pass the events totryPublishMessagesAfterCommitgave a TS error because the events didn't have a global position, even though we didn't need one for mongodbTODO
Relates to #169