Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Support Angular v17 (Nx v18.3.5) #8546

Draft
wants to merge 69 commits into
base: develop
Choose a base branch
from

Conversation

rahul-rocket
Copy link
Collaborator

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


- Updated all @nrwl/* packages to @nx/* packages in package.json
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gitguardian bot commented Nov 15, 2024

⚠️ GitGuardian has uncovered 20 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11719210 Triggered Nx Cloud Token 0b211cf nx.json View secret
11719210 Triggered Nx Cloud Token 1738810 nx.json View secret
11719210 Triggered Nx Cloud Token 451133a nx.json View secret
11719210 Triggered Nx Cloud Token 451133a nx.json View secret
11719210 Triggered Nx Cloud Token 1738810 nx.json View secret
11719210 Triggered Nx Cloud Token 0b211cf nx.json View secret
11719210 Triggered Nx Cloud Token 35bc9e2 nx.json View secret
11719210 Triggered Nx Cloud Token 35bc9e2 nx.json View secret
11719210 Triggered Nx Cloud Token bf0146c nx.json View secret
11719210 Triggered Nx Cloud Token bf0146c nx.json View secret
11719210 Triggered Nx Cloud Token 9fe80a8 nx.json View secret
11719210 Triggered Nx Cloud Token 9fe80a8 nx.json View secret
11719210 Triggered Nx Cloud Token 49fabd0 nx.json View secret
11719210 Triggered Nx Cloud Token 49fabd0 nx.json View secret
11719210 Triggered Nx Cloud Token b282b76 nx.json View secret
11719210 Triggered Nx Cloud Token b282b76 nx.json View secret
11719210 Triggered Nx Cloud Token a48108d nx.json View secret
11719210 Triggered Nx Cloud Token a48108d nx.json View secret
11719210 Triggered Nx Cloud Token 588d302 nx.json View secret
11719210 Triggered Nx Cloud Token 588d302 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

socket-security bot commented Nov 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

@rahul-rocket rahul-rocket self-assigned this Nov 15, 2024
Copy link

nx-cloud bot commented Nov 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant