Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize driver options COMPRESS keyword #166

Closed
wants to merge 2 commits into from

Conversation

hawahee
Copy link

@hawahee hawahee commented Oct 11, 2024

The write function docstring was incorrectly suggesting compression as a driver options keyword, but that does not work and has been corrected to compress.

The stringlist util function has also been updated to be less strict for the COMPRESS keyword by normalizing COMPRESSION to COMPRESS and COMPRESSED to COMPRESS.

@hawahee hawahee deleted the branch evetion:master October 11, 2024 00:56
@hawahee hawahee closed this Oct 11, 2024
@hawahee hawahee deleted the master branch October 11, 2024 00:56
@hawahee hawahee restored the master branch October 11, 2024 00:56
@hawahee hawahee reopened this Oct 11, 2024
@evetion
Copy link
Owner

evetion commented Oct 11, 2024

Thanks for the finding the typo and making PR! ❤️

Do you think we need the rename? The typo is only in the docstring, the examples in the README/docs/test are correct. If you think it matters, I would suggest to make a separate function, called check_options or similar, that checks for the typo(s) and warns when needing to rename, otherwise users are unaware of the typo.

@hawahee hawahee closed this Oct 15, 2024
@hawahee hawahee deleted the master branch October 15, 2024 18:08
@hawahee hawahee restored the master branch October 15, 2024 18:09
@hawahee hawahee deleted the master branch October 15, 2024 18:10
@hawahee hawahee restored the master branch October 15, 2024 18:15
@hawahee hawahee deleted the master branch October 15, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants