Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when passing unknown driver creation options #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hawahee
Copy link

@hawahee hawahee commented Oct 15, 2024

The write function docstring was incorrectly suggesting compression as a driver creation options keyword, but that does not work and has been corrected to compress.

The stringlist util function has also been updated to check the provided dict keywords against a list of supported driver creation options keywords, and warn when the provided keyword is unrecognized. No checking or warning is performed on the values passed together with the keywords. I could not find a list of supported driver creation options in GDAL.jl or ArchGDAL.jl, so I hardcoded a list based on the Creation Options in the GDAL GTiff documentation.

I see that the warpstringlist function calls stringlist. Does it support the same keywords, or is it for a different purpose?

Also, should the stringlist and warpstringlist input argument dict::Dict{String} be changed to dict::Dict{String,String}?

Supersedes #166

@evetion
Copy link
Owner

evetion commented Nov 21, 2024

Thanks for the PR! Mind if I make a few changes in your branch? The stringlist method should be generic (as it's used for non geotiff stuff as well), but the check for supported keywords is very helpful though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants