Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zone differences not accounted for #187

Open
mcd8604 opened this issue May 14, 2020 · 5 comments
Open

Time zone differences not accounted for #187

mcd8604 opened this issue May 14, 2020 · 5 comments

Comments

@mcd8604
Copy link

mcd8604 commented May 14, 2020

I noticed tonight that the history timestamps are saved based on the master looter's timezone. We ran two raids tonight and changed master looter. The second ML happened to have an earlier timezone and the gear drops got interspersed with the prior raid:

rclootcouncil_timestamp_issue
The two highlighted items were from BWL and the items in between came from MC which we ran an hour later.

Is it possible to save the timezone along with the timestamp?

@evil-morfar
Copy link
Owner

I'm working on revamping the time system. I'm treading carefully as it could have some backwards compatibility issues, but I'll most likely change all awards to be based on server time.

@Orphis
Copy link

Orphis commented Aug 19, 2020

When you do that, make sure to use an ISO format for dates, dd/mm/yy is totally ambiguous when you try to import it in any software and doesn't sort nicely. YYYY-MM-DD works better.
Also, there's no reason to not have the time in the same field for even easier sorting: YYYY-MM-DDThh:mm:ss

@johnbaker
Copy link

I've run into this in an external app I am working on that is based on RCLootCouncil exports. The exported timestamps would be more useful they were based on server time or if the timezone information was included with the export.

@johnbaker
Copy link

@evil-morfar is this still on the roadmap? Could there be a shorter-term step where the serverTime is added to SavedVariables and handled via import/export so we consume the data? If this is acceptable, I'd even be willing to throw together a PR.

@evil-morfar
Copy link
Owner

@evil-morfar is this still on the roadmap? Could there be a shorter-term step where the serverTime is added to SavedVariables and handled via import/export so we consume the data? If this is acceptable, I'd even be willing to throw together a PR.

It will be the next "big" thing I'll be working on, but I can't give an eta. I'd be happy to include a server time field (maybe except for in the csv export, as that requires the import to be updated as well). Even better if you'd create it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants