Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds serverTime and field on json export #262

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

johnbaker
Copy link

The following issue details the current issue with the date and time field in the data:
#187

This pull request doesn't solve the display issue as care would need to be taken with old data (without the actual serverTime value) and could lead to confusion. However, as a short-term solution for applications that may either parse the RCLootCouncil.lua saved variable or use the Json export, this pull request adds a "serverTime" field to the loot data using the GetServerTime() function which is synchronized across clients and not effected by the current user's system clock or time zone.

I didn't include the EQXML export as the and timestamps are only based on the day (and not time) and dynamically swapping between the date/time epoch and the actual server epoch based on its existence may not desired. I can add this if requested.

@evil-morfar
Copy link
Owner

Thanks for your PR, but I'm not going to merge it currently, as a rework of everything time related is on my schedule for patch 11.1. This includes switching time stamps to be server time based, and compared to this, doesn't need extra data storage.

I'm gonna leave this as is in case anyone needs it, and with a promise of implementing it for patch 11.1 if for whatever reason I'm not able to do my planned implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants