Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "Output" to "=>" - Cars Assemble (Fixes #2196) #2197

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

TristanAppDev
Copy link
Contributor

@TristanAppDev TristanAppDev commented Apr 21, 2022

Cars Assemble

For easy tracking #2202

@github-actions
Copy link
Contributor

Dear TristanAppDev

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@TristanAppDev TristanAppDev changed the title Changed "Output" to "=>" - Cars Assemble Changed "Output" to "=>" - Cars Assemble (Fixes #2196) Apr 21, 2022
@andrerfcsantos andrerfcsantos added the x:size/small Small amount of work label Apr 25, 2022
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Left some suggestions.

exercises/concept/cars-assemble/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/cars-assemble/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/cars-assemble/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/cars-assemble/.docs/instructions.md Outdated Show resolved Hide resolved
@andrerfcsantos andrerfcsantos added the status/awaiting-contributor This pull request is waiting on the contributor. label Apr 25, 2022
@exercism exercism deleted a comment from github-actions bot Jun 9, 2022
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was stuck for a long time, I committed the suggestions so we can merge.

@andrerfcsantos andrerfcsantos merged commit 5542211 into exercism:main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/awaiting-contributor This pull request is waiting on the contributor. x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants