-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed "Output"- All remaining files #2223
Conversation
Dear GabrielNSDThank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking care of this issue! This is a big one and will be great to keep consistency on the track.
I assume to do this you made a simple substitution from Output:
to =>
, which is a good starting point, but has some issues:
- The case I pointed out in the suggestion, where
output:
is part of a paragraph and must not be replaced with=>
- It was agreed upon that if a print statement is present, we should keep using
Output:
(Format the output of code examples consistently across exercises/concepts #2202). Here's an example:
result := NeedsLicense("car")
fmt.Println(result)
// Output: true
Arguably, the variable here is not needed and it is used just for the print statement, in which case, we can consider removing the print statement entirely and use the =>
syntax:
NeedsLicense("car")
// => true
So, my suggested changes would be:
- Fix the instance where
output:
is part of a paragraph. - For instances where the output follows print statements, either keep using
Output:
or check if we can remove the print statement/variables and simplify the examples like shown above. For now, I think we can keep usingOutput:
in those situations as it is easier. The simplification of the examples can be a separate issue, as it will require a lot more work and more careful checking of each exercise because the variables and the print statements might be important in some exercises. However, if you want to do that simplification in this PR, go for it and I'll make sure to size it accordingly.
@@ -64,7 +64,7 @@ func main() { | |||
} | |||
``` | |||
|
|||
Every time this program runs, it will produce the same output: | |||
Every time this program runs, it will produce the same => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The substitution here is not needed
Hello contributor and thank you for your contribution! |
There has been some interest by other contributors in fixing this issue in individual exercises, which is making this PR conflict with the main branch. The conflicts will become even more as new contributors fix this issue in more exercises. For that reason, and since reproducing this PR can be done easily with a find and replace, I'm going to close this PR. If you are still interested in solving this issue across all exercises, please create a new PR integrating the feedback in #2223 (review). |
Replace "Output:" for "=>" in example codes.
Related issue: #2202