-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update about.md in About Slices concept #2278
Conversation
Add information about merging slices with append
Dear InkognitooThank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
I think this is a great change since the exercise directly requires this and you kept it brief.
You made this change in about.md
which is fine, but this file is only shown when the student completes the exercise/concept, which is late to show this information. My suggestion is to also make this change in the concept's introduction concepts/slices/introduction.md and in the exercise's introduction exercises/concept/card-tricks/.docs/introduction.md just so the student is shown this explanation before attempting the exercise.
The exercise's introduction also includes a simpler example on how to use append with multiple arguments without using the ...
notation. I think we should also include that in this explanation:
a := []int{1, 3}
b := append(a, 4, 2) // b == []int{1,3,4,2}
I'll let you choose how you want to incorporate this example in the explanation, but I'm thinking of maybe having a paragraph + code sample explaining this simple example first and then another paragraph + code sample explaining the ...
notation. And to be clear, this extra example should be included in the 3 files, not just in the exercise's introduction.
@Inkognitoo Let us know if you are still interested in working on this. It's totally fine if you are not, we can finish this for you. If you are still interested in working on this feel free to take your time, there's no rush. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been a while. Since the changes of this PR were small and the suggestions easy to implement, I made the final changes to finish the PR.
Thanks!
Add information about merging slices with append