Describing a string as a sequence of runes is very confusing #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotp
force-pushed
the
describing-a-string-as-a-sequence-of-runes-is-very-confusing
branch
2 times, most recently
from
ce3dfa9
to
510a88f
Compare
As discussed in [the forums], this patch makes the changes desired to clarify how Strings are related to Runes and hopefully clears up some confusing and potentially misleading statements. Ref: exercism#2768 [the forums]: https://forum.exercism.org/t/potential-misleading-information-on-the-golang-runes-chapter/10082/1
This is currently identical to the concepts/runes/introduction.md file.
andrerfcsantos
force-pushed
the
describing-a-string-as-a-sequence-of-runes-is-very-confusing
branch
from
510a88f
to
66038cb
Compare
andrerfcsantos
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Thanks for this!
Rebased your branch into main and force-pushed the changes. I did this because git was complaining about a weird conflict and wouldn't let merge without it being fixed. The conflict was weird, and merging main into the branch didn't work, because when accepting all the changes in the current branch it claimed there was nothing to commit. A simple rebase did the trick.
Just letting you know about this because normally I try to not mess with other people's branches. And when I have to do it, I try to be as less invasive as I can, but I couldn't in this case :P
kotp
deleted the
describing-a-string-as-a-sequence-of-runes-is-very-confusing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversation.