Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bob: Add test cases #1753

Closed
wants to merge 2 commits into from
Closed

Bob: Add test cases #1753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ec45d4
bob: add unicode test cases
SaschaMann Dec 19, 2020
ce16854
bob: add 'bob in vienna' tests
SaschaMann Dec 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions exercises/bob/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@
},
"expected": "Whoa, chill out!"
},
{
"uuid": "c10699d2-7a89-40c8-9cd3-ed277fe1c14a",
"description": "shouting multilingual gibberish",
"scenarios": ["unicode"],
"property": "response",
"input": {
"heyBob": "FCÄEÜCÖDFCẞAB"
Copy link
Contributor Author

@SaschaMann SaschaMann Dec 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear in GitHub's fonts, but this is an uppercase ẞ, not a lowercase ß.

},
"expected": "Whoa, chill out!"
},
{
"uuid": "8a2e771d-d6f1-4e3f-b6c6-b41495556e37",
"description": "asking a question",
Expand All @@ -37,6 +47,16 @@
},
"expected": "Sure."
},
{
"uuid": "cd4b490b-b78a-4eac-beeb-70fd99353b1b",
"description": "asking a question in German",
"scenarios": ["unicode"],
"property": "response",
"input": {
"heyBob": "Hä?"
},
"expected": "Sure."
},
{
"uuid": "81080c62-4e4d-4066-b30a-48d8d76920d9",
"description": "asking a numeric question",
Expand Down Expand Up @@ -73,6 +93,16 @@
},
"expected": "Whatever."
},
{
"uuid": "98cc5157-4346-4ce1-8a0d-6833574337a1",
"description": "using acronyms in regular German speech",
"scenarios": ["unicode"],
"property": "response",
"input": {
"heyBob": "Es ist okay, wenn du nicht für den BND arbeiten möchtest."
},
"expected": "Whatever."
},
{
"uuid": "a5193c61-4a92-4f68-93e2-f554eb385ec6",
"description": "forceful question",
Expand All @@ -82,6 +112,25 @@
},
"expected": "Calm down, I know what I'm doing!"
},
{
"uuid": "7cb1a4f2-2a01-4972-b306-f995c94530b8",
"description": "forceful question in German",
"scenarios": ["unicode"],
"property": "response",
"input": {
"heyBob": "WAS ZUR HÖLLE GEHT HIER VOR?"
},
"expected": "Calm down, I know what I'm doing!"
},
{
"uuid": "e90bb162-bbfd-438c-820f-a6b09f5cdf99",
"description": "Bob in Vienna",
"property": "response",
"input": {
"heyBob": "OIDA?"
},
"expected": "Calm down, I know what I'm doing!"
},
{
"uuid": "a20e0c54-2224-4dde-8b10-bd2cdd4f61bc",
"description": "shouting numbers",
Expand Down Expand Up @@ -127,6 +176,15 @@
},
"expected": "Whoa, chill out!"
},
{
"uuid": "2a6431bd-43e3-495d-9fff-8834a387329a",
"description": "Bob in Vienna",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't tell me what is actually being tested in this test.

"property": "response",
"input": {
"heyBob": "OIDA!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to English for non-unicode examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Can you tell me an equivalent phrase/word in English then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Because Exercism's exercises are written in English. Once we cross the mutlilingual bridge, we might consider how this changes, but for now, they're in English.

Can you tell me an equivalent phrase/word in English then?

No, because I don't know what the word means, but I can refer you to the first google result:

Screenshot 2020-12-21 at 16 30 45

},
"expected": "Whoa, chill out!"
},
{
"uuid": "aa8097cc-c548-4951-8856-14a404dd236a",
"description": "statement containing question mark",
Expand Down Expand Up @@ -208,6 +266,15 @@
},
"expected": "Sure."
},
{
"uuid": "452ac3a1-daf2-473f-9ace-3de3a41dbdf8",
"description": "Bob in Vienna",
"property": "response",
"input": {
"heyBob": "Oida?"
},
"expected": "Sure."
},
{
"uuid": "72bd5ad3-9b2f-4931-a988-dce1f5771de2",
"description": "other whitespace",
Expand All @@ -225,6 +292,15 @@
"heyBob": "This is a statement ending with whitespace "
},
"expected": "Whatever."
},
{
"uuid": "16f43a00-acbe-4e36-a323-d7f48d9f29c0",
"description": "Bob in Vienna",
"property": "response",
"input": {
"heyBob": "Oida."
},
"expected": "Whatever."
}
]
}