fix : Administrators are added in spaces they are not members - EXO-76387 #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6387 Before this fix, platform administrators are added in chat space room for all spaces. This problem comes from the chat login listener which get 'accessible' spaces of users. With recents changes, accessibles spaces are spaces with template user can administrate. User must be only added in space he is member. To fix it, we replace the call in listener to getMemberSpacesByFilter instead of getAccessibleSpaces In addition, to fix current data, we add an Upgrade Plugin which check all space rooms and remove users which are not member of the space
|
Jihed525
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, platform administrators are added in chat space room for all spaces. This problem comes from the chat login listener which get 'accessible' spaces of users. With recents changes, accessibles spaces are spaces with template user can administrate. User must be only added in space he is member. To fix it, we replace the call in listener to getMemberSpacesByFilter instead of getAccessibleSpaces
In addition, to fix current data, we add an Upgrade Plugin which check all space rooms and remove users which are not member of the space