-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry: allow passing base tags #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it behaving when you do set both the environment variables and the keys
? What takes precedence?
Co-authored-by: Arnaud Geiser <[email protected]>
@arnaudgeiser the issue is that while the java sdk seems to set |
The java sdk seems to set
isEnableExternalConfiguration
by default (reading from env vars), or at the very least allows setting that option, while the clj sdk does not. The sentry-clj library is initiated without this option; it's also not possible to set it totrue
, hence we need a way to forwared some options to the sentry library.This PR forwards the
tags
;environment
andrelease
could already be passed downhttps://docs.sentry.io/platforms/java/configuration/#configuration-methods
https://github.com/getsentry/sentry-clj/?tab=readme-ov-file#additional-initialisation-options