Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-tools] use --dev false when doing npx expo export:embed --eager #462

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 5, 2024

Why

This should resolve the issue with npx expo export:embed --eager getting stuck

How

https://exponent-internal.slack.com/archives/C5ERY0TAR/p1730760976830759?thread_ts=1730716531.023659&cid=C5ERY0TAR

Use --dev false when doing npx expo export:embed --eager

Test Plan

Run command with --dev false on repro project and it wasn't stuck.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szdziedzic and the rest of your teammates on Graphite Graphite

@szdziedzic szdziedzic changed the title [build-tools] use --dev false when doing npx expo export:embed --eager [build-tools] use --dev false when doing npx expo export:embed --eager Nov 5, 2024
@szdziedzic szdziedzic requested a review from byCedric November 5, 2024 10:28
@szdziedzic szdziedzic marked this pull request as ready for review November 5, 2024 10:28
@szdziedzic szdziedzic requested a review from sjchmiela as a code owner November 5, 2024 10:28
Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member Author

szdziedzic commented Nov 5, 2024

Merge activity

  • Nov 5, 6:39 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 5, 6:40 AM EST: A user merged this pull request with Graphite.

@szdziedzic szdziedzic merged commit 01d507b into main Nov 5, 2024
5 checks passed
@szdziedzic szdziedzic deleted the 11-05-_build-tools_use_--dev_false_when_doing_npx_expo_export_embed_--eager branch November 5, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants