Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-tools] add logger to pod install spawn call in eas/install_pods custom build function #481

Conversation

szdziedzic
Copy link
Member

Why

https://exponent-internal.slack.com/archives/C02123T524U/p1736176457964409

How

It seems like we indeed forgot to pass the logger to this function. I sync this spawn call to be the same as

spawnPromise: spawn('pod', ['install'], {
cwd: iosDir,
logger: ctx.logger,
env: {
...ctx.env,
LANG: 'en_US.UTF-8',
...(ctx.env.EAS_BUILD_COCOAPODS_CACHE_URL
? { NEXUS_COCOAPODS_REPO_URL: ctx.env.EAS_BUILD_COCOAPODS_CACHE_URL }
: {}),
},
lineTransformer: (line?: string) => {
if (
!line ||
/\[!\] '[\w-]+' uses the unencrypted 'http' protocol to transfer the Pod\./.exec(line)
) {
return null;
} else {
return line;
}
},
infoCallbackFn,
}),

Test Plan

System tests - see if logs appear

@szdziedzic szdziedzic merged commit 7465ff8 into main Jan 7, 2025
4 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/fix-spawn-call-for-install-pods-custom-build-function branch January 7, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants