Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-build-job] Switch preprocess to union+transform #509

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

sjchmiela
Copy link
Contributor

Why

A union works better for generating JSON schema later, because Zod is able to infer better what is the expected input.

How

Instead of preprocessing input, we're going to transform it after parsing.

Test Plan

Tests should pass.

@sjchmiela sjchmiela requested a review from szdziedzic as a code owner February 6, 2025 12:59
@sjchmiela sjchmiela merged commit df82e68 into main Feb 6, 2025
4 checks passed
@sjchmiela sjchmiela deleted the stanley/make-stepz-more-schema-compatible branch February 6, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants