Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Use Git to resolve root path in no-VCS mode #2904

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sjchmiela
Copy link
Contributor

Why

I was thinking we can offer EAS_NO_VCS=1 as a simple escape hatch for people that are getting weird Git-related issues. One of them may be an old version of Git that does not support our git clone properly.

How

In getRootPath of no-VCS mode, return first of those values (in order):

  • EAS_PROJECT_ROOT
  • Git root path
  • process.cwd()

Test Plan

Added a basic test.

Copy link

github-actions bot commented Feb 11, 2025

Size Change: +2.13 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +2.13 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.68%. Comparing base (9bfc44b) to head (9bf2f2b).

Files with missing lines Patch % Lines
packages/eas-cli/src/vcs/clients/noVcs.ts 94.74% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2904      +/-   ##
==========================================
+ Coverage   52.66%   52.68%   +0.03%     
==========================================
  Files         588      588              
  Lines       23210    23220      +10     
  Branches     4614     4614              
==========================================
+ Hits        12221    12232      +11     
+ Misses      10955    10954       -1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csulit
Copy link

csulit commented Feb 11, 2025

Suddenly our git becomes this big. And all of our changes from new eas-build are not reflected in IOS and ANDROID production (IOS crashes in app opening)

image

@sjchmiela sjchmiela force-pushed the stanley/better-eas-no-vcs branch from 1761260 to e8f9a1a Compare February 28, 2025 14:34
Copy link

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela marked this pull request as ready for review February 28, 2025 14:46
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

@sjchmiela sjchmiela requested a review from szdziedzic February 28, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants