-
-
Notifications
You must be signed in to change notification settings - Fork 17.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repo captains #6234
base: master
Are you sure you want to change the base?
Update repo captains #6234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in itself but wasn't the purpose of the repo captain to only have one per repository? for some package it seems that half the TC is a captain, hence we don't really have one captain :D
what do you think @expressjs/express-tc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I didn't intend that when I proposed it, in fact I intended the opposite. Re reading this section though I wonder if we need to clarify:
My original intent when @gireeshpunathil and I worked on this was that we would have a few captains on each repo (for redundancy and sustainability). I could see two changes to this wording that would help clarify:
|
It would be good to include the changes proposed by @wesleytodd |
I just added myself to the packages that I plan to put a lot of energy going on 🥳
cc: @expressjs/express-tc