fix: remove download size badges #6266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheplu
approved these changes
Jan 9, 2025
UlisesGascon
approved these changes
Jan 9, 2025
ctcpip
requested changes
Jan 9, 2025
wesleytodd
force-pushed
the
remove-size-badge
branch
from
3c99def to
f960e35
Compare
ctcpip
approved these changes
Jan 9, 2025
jonchurch
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed that this was added in #5619 and would have opposed it if I had noticed. These badges are misleading in too many cases to make it worth including. Having seen some of the most wild projects and the impact of install time, I can confidently say that publishing more versions (aka the packument gets larger) is much worse of a problem than all but the most absurd cases of tarball size.
Anyway, it came up here so I thought I would open this PR to discuss.